Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update useCreateNFT to use new APIs #102

Merged
merged 5 commits into from
Dec 23, 2022
Merged

Conversation

antho1404
Copy link
Member

@antho1404 antho1404 commented Dec 21, 2022

Description

Update SDK to integrate the new API for the creation of asset

How to test

Build the library and connect to the marketplace template to test the creation of an NFT

Checklist

  • Update related changelogs
  • Update docs if necessary

@vercel
Copy link

vercel bot commented Dec 21, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
docs 🔄 Building (Inspect) Dec 23, 2022 at 7:50AM (UTC)

Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't try it yet, just some code suggestion and naming/API improvements.

docs/pages/hooks/useCreateNFT.mdx Outdated Show resolved Hide resolved
docs/pages/hooks/useCreateNFT.mdx Show resolved Hide resolved
docs/pages/hooks/useCreateNFT.mdx Show resolved Hide resolved
docs/pages/hooks/useCreateNFT.mdx Show resolved Hide resolved
packages/hooks/CHANGELOG.md Outdated Show resolved Hide resolved
packages/hooks/src/useCreateNFT.ts Show resolved Hide resolved
packages/hooks/src/useCreateNFT.ts Outdated Show resolved Hide resolved
Copy link
Member

@NicolasMahe NicolasMahe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working good 👍

package-lock.json Outdated Show resolved Hide resolved
packages/hooks/src/useCreateNFT.ts Outdated Show resolved Hide resolved
@antho1404 antho1404 merged commit e7e94c4 into main Dec 23, 2022
@antho1404 antho1404 deleted the feature/use-new-create-asset-api branch December 23, 2022 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants